chore: adjust for the Scenario 7.0 API #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyandrewmeyer
commented
Sep 6, 2024
tonyandrewmeyer
commented
Sep 6, 2024
|
@PietroPasotti could you please give this a review when you have some time? This blocks a few charms from upgrading to Scenario 7, so would be good to get out of the way. Let me know if you'd rather I took a different approach. Thanks! |
Co-authored-by: PietroPasotti <[email protected]>
PietroPasotti
requested changes
Sep 13, 2024
|
@PietroPasotti are you ok with this as it is now? |
Could you merge it for me, please? |
IronCore864
added a commit
to IronCore864/pytest-interface-tester
that referenced
this pull request
Sep 25, 2024
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the code to align with the Scenario 7.0 API changes - mostly the location of some imports and using sets in the e2e tests, but also handling the str to _Event conversion slightly differently.
This does expose
_Eventas an option toruneven though it's now private. It seems like that's ok, and leaving the ability to use the string names here is most compatible. It is possible to doCharmEvents.relation_changed(my_relation)and so on (orscenario.on.relation_changed(my_relation)if we make that change in Scenario) if people need to customise the events or don't want to do string names.